thousandeyes / terraform-provider-thousandeyes

ThousandEyes Terraform Provider
Apache License 2.0
21 stars 26 forks source link

feat: adding support for webhook notifications #164

Closed cbhoffman closed 7 months ago

cbhoffman commented 7 months ago

This will enable the use of webhook notifications within alerts using the recent SDK release.

Currently, you will receive an error if you set up alert rule notifications that use a custom webhook integration (for example, a Microsoft Teams integration data source) within Terraform.

Any feedback would be appreciated, thank you!

@joaomper-TE @shahid-te @pedro-te @phpinhei-te

joaomper-TE commented 7 months ago

@cbhoffman thanks for contributing. FYI the build is failing because of this:

https://github.com/thousandeyes/terraform-provider-thousandeyes?tab=readme-ov-file#maintainers

The docs/ folder should not be changed manually. Instead, if there are changes to the examples, inputs/outputs of any data_source or resource, you need to run go generate locally and commit the resulting changes to the .md files.
cbhoffman commented 7 months ago

@cbhoffman thanks for contributing. FYI the build is failing because of this:

https://github.com/thousandeyes/terraform-provider-thousandeyes?tab=readme-ov-file#maintainers

The docs/ folder should not be changed manually. Instead, if there are changes to the examples, inputs/outputs of any data_source or resource, you need to run go generate locally and commit the resulting changes to the .md files.

Ok thanks for letting me know, sorry about that! I'll fix this morning.

cbhoffman commented 7 months ago

When possible, can someone approve the workflow please. @joaomper-TE @shahid-te

joaomper-TE commented 7 months ago

@cbhoffman release under v2.0.8 https://github.com/thousandeyes/terraform-provider-thousandeyes/releases/tag/v2.0.8