search

thousandeyes / thousandeyes-sdk-go

Thousandeyes golang API wrapper
Apache License 2.0
12 stars 23 forks source link

Adding notification webhook structure #120

Closed cbhoffman closed 11 months ago

cbhoffman commented 12 months ago

This aims to ultimately support using webhooks for integrations within the ThousandEyes terraform provider.

Currently, if you create a custom webhook integration (for example, Microsoft Teams), you can't use it to create/update alert rules with webhook notifications (using an integration data source in terraform).

I think there just needs to be an additional struct, if this is wrong please let me know.

Any feedback would be appreciated!

cbhoffman commented 11 months ago

LGTM, thanks a lot for the contribution! Do you mind adding a test covering the new Webhook in alerts_test.go?

Test added!

cbhoffman commented 11 months ago

I'm also planning on creating a PR within the terraform-provider-thousandeyes repo. @pedro-te @raul-te @sfreitas-te may I have a code owner review when possible please. Thank you all for your work!

shahid-te commented 11 months ago

Thanks for contributing 😄

cbhoffman commented 11 months ago

Thanks for approvals and merging. Do you know when there will be a new release? @joaomper-TE @shahid-te

shahid-te commented 11 months ago

Thanks for approvals and merging. Do you know when there will be a new release? @joaomper-TE @shahid-te

Done. Your changes are in v2.4.2. We'll also update this version in terraform-provider-thousandeyes this week. You mentioned that you're planning to raise a PR in that repo. Please go ahead and tag @joaomper-TE and me for review.

cbhoffman commented 11 months ago

Thanks for approvals and merging. Do you know when there will be a new release? @joaomper-TE @shahid-te

Done. Your changes are in v2.4.2. We'll also update this version in terraform-provider-thousandeyes this week. You mentioned that you're planning to raise a PR in that repo. Please go ahead and tag @joaomper-TE and me for review.

Any updates on when terraform-provider-thousandeyes will be updated? @shahid-te

shahid-te commented 11 months ago

Thanks for approvals and merging. Do you know when there will be a new release? @joaomper-TE @shahid-te

Done. Your changes are in v2.4.2. We'll also update this version in terraform-provider-thousandeyes this week. You mentioned that you're planning to raise a PR in that repo. Please go ahead and tag @joaomper-TE and me for review.

Any updates on when terraform-provider-thousandeyes will be updated? @shahid-te

We are in release freeze due to the holidays and will release in January beginning. Apologies for any inconvenience.

cbhoffman commented 11 months ago

Hi @shahid-te, will there be a new terraform provider release this week?

joaomper-TE commented 11 months ago

Hey @cbhoffman , sorry for the long wait as we were all on 2 weeks of PTO. Will release a new version of TF provider today over this PR: https://github.com/thousandeyes/terraform-provider-thousandeyes/pull/163