search

thousandtyone / autoend

The Visual Studio Code Extension to Automatically move Semi Colons to the end of the line.
GNU General Public License v2.0
4 stars 4 forks source link

Searching for ";" inserts ";" in the document #1

Closed hekto closed 7 years ago

hekto commented 7 years ago

I'm on Mac. Cmd-F, and then type "foo;" in the search box. It will search for "foo", but the semicolon will be inserted in the current document at the cursor.

Expected behaviour would be to search for "foo;" and not modify the document.

thousandtyone commented 7 years ago

Thanks so much for reporting this. This is actually a nice catch. Will try and fix this in the next 48 hours and will post a new version. Will also comment here as soon as it's done.

thousandtyone commented 7 years ago

We've just checked in the changes and this should now be fixed. We've also published our changes in the VS Code Market Place so you can grab a new version of the extension directly from there.

I was able to reproduce the issue you mentioned on Linux and am able to verify that you can now search for text which contains a semi-colon using the Find dialog box (without having the plugin automatically and wrongly modify the open document instead). So from my side this looks fixed.

Unfortunately I cannot test this on a Mac since I am on a Linux machine. It'll be good if you can validate this is now fixed and let us know here, so we can go ahead and close this issue.

To test the fix you can:

  1. Uninstall the plugin.
  2. Install the Latest version. [The exact version where this is fixed should be 1.0.8].
  3. Close VS Code.
  4. Start VS Code fresh and test.

Again, thanks so much for reporting this. Please do let us know if this fix works for you and we'll go ahead and close this issue.

hekto commented 7 years ago

Looks good! Thanks.