thouska / spotpy

A Statistical Parameter Optimization Tool
https://spotpy.readthedocs.io/en/latest/
MIT License
254 stars 152 forks source link

Modified signatures for very low discharge rivers #159

Closed florianjehn closed 6 years ago

florianjehn commented 6 years ago

The old signatures failed with rivers that had a discharge of 0 for at least 1/3 of the time. I tried to fix this and it is working now. It would be very helpful though if someone with a deeper mathmatetical knowledge could take a look at this.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 540


Changes Missing Coverage Covered Lines Changed/Added Lines %
spotpy/hydrology/signatures.py 9 12 75.0%
<!-- Total: 9 12 75.0% -->
Files with Coverage Reduction New Missed Lines %
spotpy/algorithms/rope.py 1 89.47%
spotpy/database.py 1 88.46%
spotpy/algorithms/_algorithm.py 2 84.42%
spotpy/algorithms/fscabc.py 2 82.54%
spotpy/algorithms/abc.py 2 88.79%
spotpy/algorithms/demcz.py 3 91.67%
spotpy/describe.py 4 90.22%
spotpy/parameter.py 4 97.47%
<!-- Total: 19 -->
Totals Coverage Status
Change from base Build 536: -0.007%
Covered Lines: 4448
Relevant Lines: 4972

💛 - Coveralls