thouska / spotpy

A Statistical Parameter Optimization Tool
https://spotpy.readthedocs.io/en/latest/
MIT License
254 stars 152 forks source link

[WIP] Named parameters fail for some samplers #178

Closed philippkraft closed 6 years ago

philippkraft commented 6 years ago

Fails for mle, sa and sceua. Contains the failing tests.

Problem:

mle, sa and sceua call setup.simulation with an np.array and not with the parameter value object. Hence, one cannot use named parameters in setup.simulation as in examples/spot_setup_cmf_lumped.py

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 587


Changes Missing Coverage Covered Lines Changed/Added Lines %
spotpy/algorithms/sceua.py 4 5 80.0%
<!-- Total: 44 45 97.78% -->
Files with Coverage Reduction New Missed Lines %
spotpy/algorithms/dream.py 1 89.0%
spotpy/unittests/test_setup_parameters.py 1 96.08%
spotpy/database.py 1 88.04%
spotpy/algorithms/_algorithm.py 2 85.88%
spotpy/describe.py 4 90.22%
spotpy/algorithms/mcmc.py 4 86.59%
spotpy/parameter.py 5 97.06%
spotpy/algorithms/demcz.py 5 92.95%
<!-- Total: 23 -->
Totals Coverage Status
Change from base Build 585: 0.2%
Covered Lines: 4749
Relevant Lines: 5269

💛 - Coveralls