Closed bees4ever closed 5 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
spotpy/algorithms/dds.py | 128 | 136 | 94.12% | ||
spotpy/unittests/test_dds.py | 110 | 122 | 90.16% | ||
<!-- | Total: | 250 | 270 | 92.59% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
spotpy/algorithms/rope.py | 1 | 89.29% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 654: | -0.1% |
Covered Lines: | 5214 |
Relevant Lines: | 5762 |
Super nice work! Thank you very much for this large contribution, I think this the DDS algorithm is ready to merge now, as it has proven to provide the same results as the original matlab version. Good job :)
This is a new PR based on: https://github.com/thouska/spotpy/pull/185 where some mistakes are fixed.