thouska / spotpy

A Statistical Parameter Optimization Tool
https://spotpy.readthedocs.io/en/latest/
MIT License
254 stars 152 forks source link

When positive RMSE is used for SCE-UA, spotpy is trying to maximise it #211

Closed flydream0428 closed 5 years ago

flydream0428 commented 5 years ago

############### When the rmse is used with sce-ua, the screen feedback is trying to favor the high rmse. I checked the output database file. The output looks fine for me, it's coverging to minimize rmse. However, the screen feedback is doing somehting different. ################# Defiend objective function: def objectivefunction(self,simulation,evaluation): like = spotpy.objectivefunctions.rmse(evaluation,simulation) # return like ################# Sampler: sampler = spotpy.algorithms.sceua(spotpy_setup, dbname='SCEUA_TR_nwt_log_v2', dbformat='csv', alt_objfun=None, parallel='mpi') ####################### Screen feedback

thouska commented 5 years ago

Hi @flydream0428 Thanks for reporting this issue. As you already mentioned, this was only a printing related issue, which should be fixed with version >=1.5.0. Feel free to re-open this issue in case of any problems.

Please note: the "alt_objfun=None" keyword is not necessary any more. Spotpy is using the user defined def objectivefunction now in any case.