search

thouska / spotpy

A Statistical Parameter Optimization Tool
https://spotpy.readthedocs.io/en/latest/
MIT License
254 stars 152 forks source link

Unexpected default behavior in SCEUA algorithm #218

Closed dalmo1991 closed 5 years ago

dalmo1991 commented 5 years ago

Thank you for the great module. However some documentation is misleading (or I'm not finding the proper documentation).

I have encapsulated my model in a spotpy_setup object, implementing also my objectivefunction. I have noticed that, if I don't specify alt_objfun = None when I initialize the sampler, the algorithm uses the root mean square error. This should be specified also in the tutorials because the expected behavior is that it would use the implemented objectivefunction.

thouska commented 5 years ago

Hi @dalmo1991, thank you for your message. Are you using the most recent version of spotpy (1.5.1)? From version 1.5 on, the keyword "alt_objfun" was removed, because it was indeed a bit unexpected behavior. From now on spotpy will always use the user defined/implemented objective function. I will update the documentation accordingly.

dalmo1991 commented 5 years ago

Hi @thouska Thank you for the reply. I was using the version 1.4.6. I will move to the new one.