search

thouska / spotpy

A Statistical Parameter Optimization Tool
https://spotpy.readthedocs.io/en/latest/
MIT License
248 stars 150 forks source link

likelihoods.py, generalizedLikelihoodFunction, Line 530 - np.mean should be np.exp #245

Closed jds485 closed 4 years ago

jds485 commented 4 years ago

According to the cited paper, Line 530 of likelihoods.py should be mu_t = np.exp(muh * comparedata) instead of mu_t = np.mean(muh * comparedata)

thouska commented 4 years ago

Hi @jds485 thank you for double checking this one! Your fix is indeed correct. I uploaded your fix in a new version here on Github and on PyPi (>=1.5.10).