thouska / spotpy

A Statistical Parameter Optimization Tool
https://spotpy.readthedocs.io/en/latest/
MIT License
248 stars 150 forks source link

Update padds.py #251

Closed Jinadelee closed 4 years ago

Jinadelee commented 4 years ago

This will ensure new_value within the predefined min and max bounds

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 842


Files with Coverage Reduction New Missed Lines %
spotpy/algorithms/rope.py 1 93.58%
spotpy/algorithms/sceua.py 2 88.79%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 836: -0.07%
Covered Lines: 4131
Relevant Lines: 4593

💛 - Coveralls
thouska commented 4 years ago

Hi @Jinadelee, thanks for the contribution, this was indeed an error. Thx for the fix. Please note that, you might face other unresolved errors in padds as it is in a early beta testing-phase in spotpy, so it is, different to the other implemented algorithms, currently not ready for production use. However, your valueable contribution brings us closer to the goal of having padds robustly implemented.