thouska / spotpy

A Statistical Parameter Optimization Tool
https://spotpy.readthedocs.io/en/latest/
MIT License
254 stars 152 forks source link

add params_min/max into break point pickle #258

Closed lu-kas closed 4 years ago

lu-kas commented 4 years ago

_algorithm.py:

The variables params_min/max are not stored in the break point database. As they are not recomputed after a restart they eventually may not get updated, if no new min/max was achieved in the continued run.

Could you please check if there may be other candidates like this?

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 878


Changes Missing Coverage Covered Lines Changed/Added Lines %
spotpy/algorithms/_algorithm.py 0 4 0.0%
<!-- Total: 0 4 0.0% -->
Files with Coverage Reduction New Missed Lines %
spotpy/algorithms/_algorithm.py 1 86.12%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 877: -0.04%
Covered Lines: 4146
Relevant Lines: 4619

💛 - Coveralls
thouska commented 4 years ago

@lu-kas thx for your message, indeed these candidates were missing. So far I did not find other candidates, therefor I think we can merge your contribution and hope this is working fine now.