search

thp / urlwatch

Watch (parts of) webpages and get notified when something changes via e-mail, on your phone or via other means. Highly configurable.
https://thp.io/2008/urlwatch/
Other
2.81k stars 352 forks source link

reporters: report jobs separately #721

Closed ryneeverett closed 1 year ago

ryneeverett commented 1 year ago

Adapted from https://github.com/thp/urlwatch/pull/305.

I made some adjustments per the review comment:

2. The `separate` key is nowhere documented or put into the example config, also please rethink where we place the separate key -- should it be per-reporter or a global config?

Is this what you had in mind?

ryneeverett commented 1 year ago

Moving the option into the format-specific configuration sections makes sense to me given the current configuration hierarchy. Wouldn't it also make sense for it to go into html?

thp commented 1 year ago

Moving the option into the format-specific configuration sections makes sense to me given the current configuration hierarchy. Wouldn't it also make sense for it to go into html?

Yes, of course, html also makes sense.

scottmac commented 1 year ago

I'm interested in this change, @ryneeverett are you ready for another review?

thp commented 1 year ago

Please rebase against master so that the CI tests can run though (see #733).

thp commented 1 year ago

Merged, thanks!