thp / urlwatch

Watch (parts of) webpages and get notified when something changes via e-mail, on your phone or via other means. Highly configurable.
https://thp.io/2008/urlwatch/
Other
2.81k stars 352 forks source link

Shell reporter not working #740

Closed notDavid closed 1 year ago

notDavid commented 1 year ago

Hi there, so I'm trying https://github.com/thp/urlwatch/commit/7c505657c7ccfe78060240ef5f09b21fd86cea13 but i can't get it to work;

it seems whatever i do, nothing is reported. If i disable all other reporters, and only keep the shell one, i get: reporters WARNING: No reporters enabled.

It seems as if it's not being triggered? In urlwatch.yaml i've configured:

report:
  shell:
    # command: ['/home/ubuntu/.local/bin/ntfyr', '--topic', 'hello', '--title', 'urlwatch']
    command: ['tee', '-a', '/home/ubuntu/tmp/log.txt']
    ignore_stdout: false
    enabled: true

No errors are logged. Could it be some bug in de code? Please advise :-)

-- urlwatch 2.25

thp commented 1 year ago

The shell reporter is new and has been added after 2.25, it's not yet part of a release: CHANGELOG.md

It will be part of the next release, but as some things are currently landing in the master branch and some things seem to be regressing (e.g. #745), it might take a few more days until the next release is done -- but other than that, I think it's already time for another release (once the changes have slowed down a little and no new issue reports come up for a few days).

thp commented 1 year ago

In other words, if you want to use the shell reporter right now, install from Git (google for "pip install from git" for instructions). Be aware that the in-development version might have issues, so make sure to update regularly if you're tracking development in Git.

notDavid commented 1 year ago

Ahh that explains... thank you @thp :-)

notDavid commented 1 year ago

@thp PS. Would be convenient if you'd enable the Releases when a version is released, so people can follow and get notified of updates 😊

thp commented 1 year ago

It should be possible to watch the tags. Right now, nobody has bothered to automate the Github Releases submission yet.