search

thp / urlwatch

Watch (parts of) webpages and get notified when something changes via e-mail, on your phone or via other means. Highly configurable.
https://thp.io/2008/urlwatch/
Other
2.81k stars 352 forks source link

--gc-cache does not delete unused keys from redis db #743

Closed trevorshannon closed 1 year ago

trevorshannon commented 1 year ago

When using a redis cache, the --gc-cache option successfully removes old entries, but does not delete old keys (despite claiming to do so). This seems to be due to a string/bytes type issue somewhere around here.

When deleting unused keys, the system attempts to remove e.g. "guid:b'27687e4f702f8547973bc60451b4f1539ee3d428'" instead of "guid:27687e4f702f8547973bc60451b4f1539ee3d428"

thp commented 1 year ago

Yeah, the problem with the Redis support is that at least I don't test it regularly.

It was added by @scottmac in #491. I don't have an overview of how popular the Redis support is.

If it's not easy to test/verify, then maybe eventually removing the Redis support is a good idea?

(cc'd @scottmac to chime in)

scottmac commented 1 year ago

I’ll fix it, looks straightforward