search

thp / urlwatch

Watch (parts of) webpages and get notified when something changes via e-mail, on your phone or via other means. Highly configurable.
https://thp.io/2008/urlwatch/
Other
2.81k stars 352 forks source link

Migrate from pyppeteer to playwright-python #761

Closed paulsattlegger closed 1 year ago

paulsattlegger commented 1 year ago

Having previously used a workaround to get the browser job to work on ARM devices, I have spent some time searching for a better approach. Rather than relying on the unmaintained dependency Pyppeteer, I would recommend switching to Playwright. Playwright is actively maintained by Microsoft (including the Python bindings), and provides a clean API that simplifies the browser job code. I have also updated the documentation related to the browser job. If there is anything else that needs to be done, I am happy to help.

polyzen commented 1 year ago

Resolves #751

thp commented 1 year ago

Thanks, merged and released in urlwatch 2.28 (with some backwards compatibility and docs changes).