thp / urlwatch

Watch (parts of) webpages and get notified when something changes via e-mail, on your phone or via other means. Highly configurable.
https://thp.io/2008/urlwatch/
Other
2.82k stars 351 forks source link

Applies larger line spacing only to diff tables. #777

Closed trevorshannon closed 10 months ago

trevorshannon commented 10 months ago

This reverts the <body> line-height adjustment introduced in #730 and instead applies it to <table> elements so that the increased line-height only applies to HTML table diffs. This higher line height was originally introduced to emulate the GitHub web diff rendering.

With this change, text-based diffs will go back to regular line heights. See #774

As a visual, here are the results of diff: table and diff: unified for the html reporter. Note that these were rendered in Chrome as different email clients can render the HTML differently (e.g. web Gmail ignores the line-height anyway)

Table (note 1.5 line height)

Screenshot 2023-12-01 at 6 01 42 PM

Unified (note 1.0 line height)

Screenshot 2023-12-01 at 6 02 55 PM