SlackReporter with preformatted rich text

thp / urlwatch

Watch (parts of) webpages and get notified when something changes via e-mail, on your phone or via other means. Highly configurable.

https://thp.io/2008/urlwatch/

Other

2.82k stars 351 forks source link

SlackReporter with preformatted rich text #780

Closed vimagick closed 2 months ago

vimagick commented 10 months ago

Hi, I've updated my code ( #776 )

Three things:

[x] Have you checked whether or not Mattermost supports Slack's rich text feature?

Mattermost still use the original {"text": text}
[x] How about users who want to opt out of this new behavior and have the old (non-rich-text) behavior? Should there be an option? What should be the default?

Enabled only when rich_text: true
[x] Please update CHANGELOG.md with information about this change

Yes

thp commented 6 months ago

@vimagick Did you have time to look into these?

[ ] Can you add 'rich_text': False, to lib/urlwatch/storage.py in the 'slack': section, so that it's easily discoverable?

[ ] Can you add documentation for this to the Slack section in docs/source/reporters.rst

thp commented 5 months ago

@vimagick Needs rebasing, and there's still the two items from above. Thanks!

thp commented 2 months ago

Closing after no activity. Feel free to reopen and update the PR.