search

thp / urlwatch

Watch (parts of) webpages and get notified when something changes via e-mail, on your phone or via other means. Highly configurable.
https://thp.io/2008/urlwatch/
Other
2.79k stars 350 forks source link

Consider releasing version 2.29 #807

Open maclomhair opened 4 months ago

maclomhair commented 4 months ago

It seems that version 5 of python-lxml doesn't support using the old "CSSSelector evaluate" style. As this version is now slowly landing in the repos of distributions, urlwatch 2.28 needs patches to continue working. However, the new call style is already implemented in the urlwatch master branch, so releasing a new version would keep urlwatch working without patches in distros upgrading python-lxml. Thank you for your great work!

Jamstah commented 4 months ago

We also have #806 in flight which works around new behaviour in python 3.12.2, which is also landing in distro repos.

With those two in, I agree, a new release makes sense.

maclomhair commented 4 months ago

Great news! Thank you, also for the quick response!

Jamstah commented 4 months ago

I don't know about great news, I agree for the need but don't have the power to do it!

That responsibility rests on the shoulders of @thp alone. I only try to help where I can.

dairiki commented 3 months ago

Why was this issue marked as completed? The latest release on PyPI is still 2.28 (from May 2023).

As things stand, in order for the css filter to work, one must manually pin lxml < 5 (ref #784) when installing urlwatch from PyPI.

PR #786 fixes things in the master branch, but that is not available from PyPI. A new release should continue to be considered.

hohav commented 2 months ago

@thp ping for visibility. This issue should still be open.