[CLOSED] Fuzzy JUnit failures

thpar / diffany

Diffany is an open-source toolbox for calculating and visualizing differential networks.

7 stars 2 forks source link

[CLOSED] Fuzzy JUnit failures #168

Closed diffany-admin closed 9 years ago

diffany-admin commented 9 years ago

Issue by svlandeg Tue Jul 29 07:41:25 2014

Inconsistent failures in the TestFuzzyOverlap class after introducing Network IDs and refactoring the EdgeComparison a bit to accomodate #166

diffany-admin commented 9 years ago

Comment by svlandeg Tue Jul 29 07:52:42 2014

with overlap cutoff 1, and "testwithoutreference", the directed PPI B-A link sometimes gets weight 0.4, sometimes 0.8

diffany-admin commented 9 years ago

Comment by svlandeg Tue Jul 29 11:00:55 2014

The trouble was caused by the NetworkCleaning class altering the input set instead of creating an independent set! The input edges should never be changed temselves but cloned and then altered!