THCRAP/THTK causes memory leak

thpatch / thcrap

Touhou Community Reliant Automatic Patcher

https://www.thpatch.net

The Unlicense

558 stars 41 forks source link

THCRAP/THTK causes memory leak #140

Closed Oreeeee closed 3 years ago

brliron commented 3 years ago

Is this thcrap or thtk? They have almost nothing in common, a memory leak in one will probably not be in the other.
How are you running it?
- For thcrap, we need at least the game and patch stack. The full log file could help.
- For thtk, we need to know which tool, and which parameters you used.

DankRank commented 3 years ago

It's in logs/thcrap_log.txt in the directory where you have thcrap

brliron commented 3 years ago

For thtk, if it works correctly, you shouldn't be able to see a memory leak after a few minutes, because the tool doesn't run for a few minutes. I just tried it on my end, with the following command:

thdat -x 8 th08.dat

using the last thtk version from https://github.com/thpatch/thtk/releases/tag/12 and a th08.dat with a sha256 of 9D7EDF43B8DDD347CBB641836F6B5050745DD936F688DAEBBF9382CA557043BB, the tool does its job in about 3 seconds and exits.

brliron commented 3 years ago

You're welcome :)