thpatch / thcrap

Touhou Community Reliant Automatic Patcher
https://www.thpatch.net
The Unlicense
558 stars 41 forks source link

Mojibake on Spell Cards names in TH08 Spell Practice #142

Closed chrisGrando closed 3 years ago

chrisGrando commented 3 years ago

For some reason, thcrap seems to not recognize special characters in Spell Cards names into Spell Practice menu, and replaces any kind of non-ASCII characters with mojibake (As illustrated below). snapshot

Details:

Reply to me if you need more information.

brliron commented 3 years ago

Things like this often happen when a string contains both UTF-8 and shift-jis (this usually happens when we have a mix of something from thcrap, in UTF-8, and something from the game, in shift-jis). The part "Futuro [...]" obviously comes from thcrap, and I would guess that "No. 194 " comes from the game and contains a shift-jis chatacter. I would also guess that lang_en replaces this with a non-shift-jis version, which explains why all the languages that depend on lang_en didn't notice but you did (lang_pt-br doesn't depend on lang_en). I'm looking at it for more details.

brliron commented 3 years ago

Oh wait, this is spell practice. For some reason I thought this was the music room.

which explains why all the languages that depend on lang_en didn't notice but you did

Nvm, even languages that depend on lang_en have this problem.

brliron commented 3 years ago

Fixed in base_tsa. You will get the fix the next time you run the game.