thpatch / thcrap

Touhou Community Reliant Automatic Patcher
https://www.thpatch.net
The Unlicense
565 stars 42 forks source link

Configure: improve defaults after rescan? #220

Open brliron opened 1 year ago

brliron commented 1 year ago

Choosing a default game during a rescan can be hard. Yet, it's important because many users don't even know you can change the default (which is probably an UI problem, but that's another question). If a rescan finds a new version for an existing game, I think I prefer to try keeping the old version. If this is for example EoSD or another game that keeps its save data in its own directory, choosing another game version could lead to the user losing their save data (not actually losing it, it would still be there in the previous game installation, but that's what it would look like for the end user).

On the other hand, a rescan could also happen because the user moved their games. In this case, he would prefer to have the new games. This case can actually be detected with decent reliability: if the old path doesn't exist, we shouldn't keep using it, and we can start using the new one. ... Unless the game is on an USB drive which happened to be disconnected during the rescan. In which case we would want to keep it.

Anyway, it's not as easy of a choice than it looks like at first glance, but it's worth discussing and trying to see if we can improve things.