thpatch / thcrap

Touhou Community Reliant Automatic Patcher
https://www.thpatch.net
The Unlicense
547 stars 40 forks source link

"Find games automatically" should search "C:\Program Files (x86)\上海アリス幻樂団" #234

Open lilyremigia opened 10 months ago

lilyremigia commented 10 months ago

"Find games automatically" should search C:\Program Files (x86)\上海アリス幻樂団

ZUN's installer places the games here, by default. Touhou 19's DLsite version, for example. image

brliron commented 10 months ago

We look in the registry key HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall for subkeys whose name starts with either 東方, or 弾幕アマノジャク (special case for th14.3). What does the registry uninstall key for th19 look like?

lilyremigia commented 10 months ago

image

lilyremigia commented 10 months ago

th19.reg.txt

lilyremigia commented 10 months ago

@brliron Because regularly installed games aren't Steam games, they get filtered out here. https://github.com/thpatch/thcrap/blob/beb32924fc0034c46c848f1bcc8788f1f4d4e561/thcrap/src/search.cpp#L366C46-L366C46

lilyremigia commented 10 months ago

But also, it's only in WOW6432Node. At least on Win11.

brliron commented 9 months ago

I completely forgot that I didn't implement official installers detection in #111 yet.