search

thpatch / thcrap

Touhou Community Reliant Automatic Patcher
https://www.thpatch.net
The Unlicense
547 stars 40 forks source link

[thcrap] Only display not being able to digitally sign once. #243

Open lilyremigia opened 9 months ago

lilyremigia commented 9 months ago

11>d:\repos\thcrap\thcrap\thcrap\src\runconfig.cpp(361): warning C4834: discarding return value of function with 'nodiscard' attribute

Also, I feel like the warning about digital signing doesn't have to happen every project...

16>D:\Repos\thcrap\thcrap\Base.props(60,5): warning : D:\Repos\thcrap\thcrap\cert.pfx not found. Binaries won't be digitally signed, and thcrap won't be able to automatically update itself.
16>D:\Repos\thcrap\thcrap\Base.props(60,5): warning : Please see README.md for instructions on how to generate this file.
brliron commented 7 months ago

The warning have been fixed. The release script warns me on warnings and errors, so we usually don't keep them for too long.

As for the thing about digital signing, I'll admit that I don't have this problem because I have a certificate in my build directory (I think that's a test certificate, but it may be the prod one). I think we could improve things on that side. The test certificate could be added to the git repository, which could help with automated testing, and we could try to find a way to have the warning only while building for release, and to have a warning if the certificate supplied doesn't match the sha256 of my prod certificate.