search

thpatch / thcrap

Touhou Community Reliant Automatic Patcher
https://www.thpatch.net
The Unlicense
558 stars 41 forks source link

tasofro: fix th123 preferring th105 spell comments over its own #262

Closed DTM9025 closed 1 month ago

DTM9025 commented 1 month ago

Right now, if there are duplicate keys for spell comments between TH123 and TH105, it will show the comments of TH105. This small change will make it so the ones for TH123 are shown and only use TH105 comments as a fallback.

(This mainly affects the common cards as I think character cards don't actually overlap)

brliron commented 1 month ago

This has the problem of relying on the order things in something called an "unordered map".

zero's solution in https://github.com/thpatch/thcrap/commit/69edd976d320d26a41016ffbe5aa69500e7ec80c makes the order consistent.