search

thpatch / thtk

Touhou Toolkit
https://thtk.thpatch.net/
Other
307 stars 43 forks source link

remove OpenMP and unlocked stdio? #93

Open DankRank opened 2 years ago

DankRank commented 2 years ago

This stuff existed from the very beginning of thtk, but I wonder if there's actually any point in it. I made these two commits in order to be able to do comparisons. I don't wanna do it right now though, so I'll let this code sit here in case anyone else wants to benchmark.

I'm fine with keeping unlocked stdio if it has any gains, because the stuff is obviously correct. I'm not so sure with OpenMP, at it causes #52, and that's enough of a reason to get rid of it IMO.

DankRank commented 2 years ago

Fun fact, older versions of OpenMP didn't allow unsigned loop indexes, and using them caused UB. We don't have that problem, as the last instance of it was fixed in 189daa557cd8c1d8134472501b8a42b1ce27cc79.

DankRank commented 1 year ago

a bug related to OpenMP was fixed recently. 7503f341db3a330f546ce2185593f025be6d1e58

i'm honestly not very stoked about the fact that the order in which the files are written relies on omp scheduling.