New Useful Win32 Function Wrappers

bluecataudio commented 3 years ago

Added a couple of useful function wrappers.
Defined CallWindowProc as CallWindowProcW. Many features do not work propery otherwise (window titles, and many text-based controls).

DankRank commented 3 years ago

I've prepared this for merging into master.

Changed spaces to tabs, and other formatting stuff
Added the new functions to win32_utf8.def
Added CallWindowProc to user32_pairs
GetTempFileNameU assumed that the underlying function returned string length, which isn't the case (it returns the random number that's part of the filename). Also there was no error checking.
IsolationAwareMessageBox is actually an inline function in winuser.inl, and is not exported by user32. And it is only declared conditionally, when ISOLATION_AWARE_ENABLED is enabled. This leads to a compilation error when building the DLL, since we don't define that (and we probably shouldn't, since the isolation aware functions are supposed to be per-DLL). The solution is to have the application pass a pointer to its copy of IsolationAwareMessageBoxW. This is hidden behind a macro of course.

https://github.com/thpatch/win32_utf8/tree/New-Wrappers-Fix https://github.com/thpatch/win32_utf8/compare/master...New-Wrappers-Fix

@bluecataudio: Try out this code with your application and tell us the results. In particular check that the new GetTempFileNameU and IsolationAwareMessageBoxU work correctly.

bluecataudio commented 3 years ago

It looks all good and works fine here. Thanks for taking the time to fix and incorporate the changes! That's a great library!

brliron commented 3 years ago

Oops, I just noticed this pull request was still open. I merge DankRank's New-Wrappers-Fix branch into master and close this.

thpatch / win32_utf8

New Useful Win32 Function Wrappers #9