common/timedmutex: clean and improve

[shazbert]

PR Description

• Reduce go routine spawn and inline waitgroup action when calling LockForDuration
• reuse timer instead of allocating on every potential rest call
• rm rw mutex if nonce not required it shouldn't lock anyway so might be able to read field exposed without protection, if not it will be a rolling gate with the main mutex. Didn't work so added an atomic.Bool.
• Add benchmark comment from master to this.

Fixes # (issue)

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and also consider improving test coverage whilst working on a certain feature or package.

• [ ] go test ./... -race
• [ ] golangci-lint run
• [ ] Test X

Checklist

• [ ] My code follows the style guidelines of this project
• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally and on Github Actions with my changes
• [ ] Any dependent changes have been merged and published in downstream modules

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 35.87%. Comparing base (d679a76) to head (d15bf03). Report is 3 commits behind head on master.

:exclamation: Current head d15bf03 differs from pull request most recent head 150f9d4. Consider uploading reports for the commit 150f9d4 to get more accurate results

Additional details and impacted files

[](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) ```diff @@ Coverage Diff @@ ## master #1486 +/- ## ========================================== - Coverage 35.89% 35.87% -0.02% ========================================== Files 411 411 Lines 177595 177528 -67 ========================================== - Hits 63752 63697 -55 - Misses 106058 106065 +7 + Partials 7785 7766 -19 ``` | [Files](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1486?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) | Coverage Δ | | |---|---|---| | [common/timedmutex/timed\_mutex.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-Y29tbW9uL3RpbWVkbXV0ZXgvdGltZWRfbXV0ZXguZ28=) | `89.28% <95.00%> (-1.20%)` | :arrow_down: | ... and [28 files with indirect coverage changes](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1486/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)