search

thrasher-corp / gocryptotrader

A cryptocurrency trading bot and framework supporting multiple exchanges written in Golang.
MIT License
2.96k stars 792 forks source link

Tests: Abstract UpdatePairsOnce #1503

Closed gbjk closed 4 months ago

gbjk commented 4 months ago

Abstracts updatePairsOnce for use in several branches including #1482

Type of change

How has this been tested

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 35.89%. Comparing base (d679a76) to head (ed22da9). Report is 1 commits behind head on master.

:exclamation: Current head ed22da9 differs from pull request most recent head 094e224. Consider uploading reports for the commit 094e224 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1503/graphs/tree.svg?width=650&height=150&src=pr&token=41784B23TS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) ```diff @@ Coverage Diff @@ ## master #1503 +/- ## ========================================== - Coverage 35.89% 35.89% -0.01% ========================================== Files 411 411 Lines 177595 177608 +13 ========================================== - Hits 63752 63744 -8 - Misses 106058 106079 +21 Partials 7785 7785 ``` | [Files](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1503?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) | Coverage Δ | | |---|---|---| | [internal/testing/exchange/exchange.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-aW50ZXJuYWwvdGVzdGluZy9leGNoYW5nZS9leGNoYW5nZS5nbw==) | `59.64% <92.85%> (+5.19%)` | :arrow_up: | ... and [16 files with indirect coverage changes](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1503/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)