Closed gbjk closed 3 months ago
I'm not liking those failures in kraken's TestWsOpenOrders
; Sniffing it now
TestWsOpenOrders errors were unrelated. This is good to review.
Already in the next upcoming branch.
I've got significant testing of Subscribe in there without mocking, so I'm on the fence about adding a mock for it if we don't have to ( perversely ).
Anyway, Let's touch on this when that PR lands.
Attention: Patch coverage is 83.01887%
with 9 lines
in your changes are missing coverage. Please review.
Project coverage is 36.02%. Comparing base (
b909e15
) to head (e7e5a5e
). Report is 2 commits behind head on master.
Rebased and ready to roll 😄
We were using the "cancel many" facility of the Kraken api. However since that doesn't actually report errors individually, it seems saner to just multiplex over it. We were going to get N+ responses anyway. Might as well send N+ requests
One thing I'm unhappy about is the change of Key/Secret for this to work. I really don't like that there's special values for the auth values which get silently ignored, such as Test, Mock, Key, Secret, etc. So I've ended up using something adhoc, and putting a require in the test to ensure it's obvious if the auth-conn isn't connected.
Type of change
How has this been tested