request/nonce: simplify and prevent two consecutive mutex lock calls

[shazbert]

PR Description

Requires #1486

Attempts to improve flow when deriving a nonce.

• Also changes function signature so the nonce package doesn't need to handle setting different values, this can be defined caller side so that anything can be put in, so we don't need to do anything in the future if milliseconds, microseconds, 1 etc need to be added later.

Fixes # (issue)

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and also consider improving test coverage whilst working on a certain feature or package.

• [ ] go test ./... -race
• [ ] golangci-lint run
• [ ] Test X

Checklist

• [ ] My code follows the style guidelines of this project
• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally and on Github Actions with my changes
• [ ] Any dependent changes have been merged and published in downstream modules

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 37.83%. Comparing base (5b2251b) to head (0baf92c). Report is 1 commits behind head on master.

Additional details and impacted files

[](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) ```diff @@ Coverage Diff @@ ## master #1506 +/- ## ========================================== + Coverage 35.96% 37.83% +1.86% ========================================== Files 411 411 Lines 177329 147507 -29822 ========================================== - Hits 63773 55804 -7969 + Misses 105782 83919 -21863 - Partials 7774 7784 +10 ``` | [Files](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1506?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) | Coverage Δ | | |---|---|---| | [exchanges/bitstamp/bitstamp.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1506?src=pr&el=tree&filepath=exchanges%2Fbitstamp%2Fbitstamp.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2JpdHN0YW1wL2JpdHN0YW1wLmdv) | `82.14% <100.00%> (+2.91%)` | :arrow_up: | | [exchanges/gemini/gemini.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1506?src=pr&el=tree&filepath=exchanges%2Fgemini%2Fgemini.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2dlbWluaS9nZW1pbmkuZ28=) | `75.49% <100.00%> (+3.92%)` | :arrow_up: | | [exchanges/nonce/nonce.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1506?src=pr&el=tree&filepath=exchanges%2Fnonce%2Fnonce.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL25vbmNlL25vbmNlLmdv) | `100.00% <100.00%> (ø)` | | | [exchanges/poloniex/poloniex.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1506?src=pr&el=tree&filepath=exchanges%2Fpoloniex%2Fpoloniex.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL3BvbG9uaWV4L3BvbG9uaWV4Lmdv) | `41.63% <100.00%> (+3.20%)` | :arrow_up: | | [exchanges/alphapoint/alphapoint.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1506?src=pr&el=tree&filepath=exchanges%2Falphapoint%2Falphapoint.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2FscGhhcG9pbnQvYWxwaGFwb2ludC5nbw==) | `11.29% <0.00%> (+0.44%)` | :arrow_up: | | [exchanges/bitfinex/bitfinex.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1506?src=pr&el=tree&filepath=exchanges%2Fbitfinex%2Fbitfinex.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2JpdGZpbmV4L2JpdGZpbmV4Lmdv) | `28.05% <0.00%> (+1.82%)` | :arrow_up: | | [exchanges/exmo/exmo.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1506?src=pr&el=tree&filepath=exchanges%2Fexmo%2Fexmo.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2V4bW8vZXhtby5nbw==) | `36.42% <0.00%> (+1.26%)` | :arrow_up: | | [exchanges/kraken/kraken.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1506?src=pr&el=tree&filepath=exchanges%2Fkraken%2Fkraken.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2tyYWtlbi9rcmFrZW4uZ28=) | `56.40% <0.00%> (+1.18%)` | :arrow_up: | | [exchanges/yobit/yobit.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1506?src=pr&el=tree&filepath=exchanges%2Fyobit%2Fyobit.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL3lvYml0L3lvYml0Lmdv) | `61.38% <0.00%> (+0.01%)` | :arrow_up: | | [exchanges/request/request.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1506?src=pr&el=tree&filepath=exchanges%2Frequest%2Frequest.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL3JlcXVlc3QvcmVxdWVzdC5nbw==) | `74.45% <37.50%> (+4.85%)` | :arrow_up: | ... and [378 files with indirect coverage changes](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1506/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)