search

thrasher-corp / gocryptotrader

A cryptocurrency trading bot and framework supporting multiple exchanges written in Golang.
MIT License
2.96k stars 792 forks source link

Currency: Remove Pair Index formatting/parsing #1520

Closed gbjk closed 3 months ago

gbjk commented 3 months ago

This feature was originally for exchanges with only one pair (e.g. KRW) which made parsing easier. However there's no examples of this left, and we can reduce complexity overall by removing it.

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

How has this been tested

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.89%. Comparing base (7b842c2) to head (cc514ac).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1520/graphs/tree.svg?width=650&height=150&src=pr&token=41784B23TS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) ```diff @@ Coverage Diff @@ ## master #1520 +/- ## ========================================== + Coverage 36.04% 37.89% +1.84% ========================================== Files 411 411 Lines 176906 147165 -29741 ========================================== - Hits 63765 55764 -8001 + Misses 105356 83616 -21740 Partials 7785 7785 ``` | [Files](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1520?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) | Coverage Δ | | |---|---|---| | [config/config.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1520?src=pr&el=tree&filepath=config%2Fconfig.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-Y29uZmlnL2NvbmZpZy5nbw==) | `87.57% <100.00%> (+0.82%)` | :arrow_up: | | [currency/currency.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1520?src=pr&el=tree&filepath=currency%2Fcurrency.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-Y3VycmVuY3kvY3VycmVuY3kuZ28=) | `84.84% <100.00%> (+4.56%)` | :arrow_up: | | [currency/pair.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1520?src=pr&el=tree&filepath=currency%2Fpair.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-Y3VycmVuY3kvcGFpci5nbw==) | `86.07% <ø> (-0.34%)` | :arrow_down: | | [currency/pairs.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1520?src=pr&el=tree&filepath=currency%2Fpairs.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-Y3VycmVuY3kvcGFpcnMuZ28=) | `98.46% <100.00%> (+0.36%)` | :arrow_up: | ... and [384 files with indirect coverage changes](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1520/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)
gbjk commented 3 months ago

Please also change the Bithumb config_example to make it in line with the test config: https://github.com/thrasher-corp/gocryptotrader/blob/master/config_example.json#L708

Fixed 4189789