thrasher-corp / gocryptotrader

A cryptocurrency trading bot and framework supporting multiple exchanges written in Golang.
MIT License
2.95k stars 793 forks source link

Test: Internal exchange coverage #1525

Closed gbjk closed 2 months ago

gbjk commented 2 months ago

Minimal test coverage for internal/testing/exchange. It doesn't cover all statements or methods, but at least gets us started in the right direction.

Type of change

How has this been tested

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 36.01%. Comparing base (ece58eb) to head (9dd97f6).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1525/graphs/tree.svg?width=650&height=150&src=pr&token=41784B23TS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) ```diff @@ Coverage Diff @@ ## master #1525 +/- ## ========================================== - Coverage 36.01% 36.01% -0.01% ========================================== Files 411 412 +1 Lines 177760 177779 +19 ========================================== + Hits 64025 64030 +5 - Misses 105881 105894 +13 - Partials 7854 7855 +1 ``` | [Files](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1525?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) | Coverage Δ | | |---|---|---| | [internal/testing/exchange/exchange.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1525?src=pr&el=tree&filepath=internal%2Ftesting%2Fexchange%2Fexchange.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-aW50ZXJuYWwvdGVzdGluZy9leGNoYW5nZS9leGNoYW5nZS5nbw==) | `50.80% <62.50%> (-13.90%)` | :arrow_down: | | [internal/testing/utils/path.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1525?src=pr&el=tree&filepath=internal%2Ftesting%2Futils%2Fpath.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-aW50ZXJuYWwvdGVzdGluZy91dGlscy9wYXRoLmdv) | `71.42% <71.42%> (ø)` | | ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1525/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)
gbjk commented 2 months ago

I will ask you to look at the build issues here: https://github.com/thrasher- It looks like ARM64 Windows is unable to work with your changes.

Fixed 66741a6