thrasher-corp / gocryptotrader

A cryptocurrency trading bot and framework supporting multiple exchanges written in Golang.
MIT License
2.95k stars 793 forks source link

btcmarkets: remove trailing slash on markets/ticker strings and update endpoint pathways #1530

Closed shazbert closed 2 months ago

shazbert commented 2 months ago

PR Description

BTC markets woke up one day and banned the trailing slash. This hopefully appeases the BTCM gods.

Fixes # (issue)

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and also consider improving test coverage whilst working on a certain feature or package.

Checklist

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.02%. Comparing base (1e95ae9) to head (3ea45ef). Report is 1 commits behind head on master.

:exclamation: Current head 3ea45ef differs from pull request most recent head a53bea7. Consider uploading reports for the commit a53bea7 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1530/graphs/tree.svg?width=650&height=150&src=pr&token=41784B23TS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1530?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) ```diff @@ Coverage Diff @@ ## master #1530 +/- ## ========================================== - Coverage 37.91% 36.02% -1.90% ========================================== Files 411 411 Lines 147198 176914 +29716 ========================================== + Hits 55817 63740 +7923 - Misses 83588 105395 +21807 + Partials 7793 7779 -14 ``` | [Files](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1530?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) | Coverage Δ | | |---|---|---| | [exchanges/btcmarkets/btcmarkets.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1530?src=pr&el=tree&filepath=exchanges%2Fbtcmarkets%2Fbtcmarkets.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2J0Y21hcmtldHMvYnRjbWFya2V0cy5nbw==) | `24.14% <100.00%> (-1.08%)` | :arrow_down: | ... and [387 files with indirect coverage changes](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1530/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)