thrasher-corp / gocryptotrader

A cryptocurrency trading bot and framework supporting multiple exchanges written in Golang.
MIT License
2.95k stars 793 forks source link

currency: add function FindMatchingPairs #1531

Closed shazbert closed 1 month ago

shazbert commented 2 months ago

PR Description

This is just cherry-picked from an external branch if any body wants it. Can close if not.

Fixes # (issue)

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and also consider improving test coverage whilst working on a certain feature or package.

Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 36.03%. Comparing base (f1ff951) to head (67e3393). Report is 13 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1531/graphs/tree.svg?width=650&height=150&src=pr&token=41784B23TS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1531?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) ```diff @@ Coverage Diff @@ ## master #1531 +/- ## ========================================== - Coverage 36.03% 36.03% -0.01% ========================================== Files 411 411 Lines 177750 177770 +20 ========================================== - Hits 64061 64051 -10 - Misses 105839 105864 +25 - Partials 7850 7855 +5 ``` | [Files](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1531?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) | Coverage Δ | | |---|---|---| | [currency/pairs.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1531?src=pr&el=tree&filepath=currency%2Fpairs.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-Y3VycmVuY3kvcGFpcnMuZ28=) | `97.25% <85.00%> (-0.80%)` | :arrow_down: | ... and [16 files with indirect coverage changes](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1531/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)
shazbert commented 1 month ago

close in favour of #1556