thrasher-corp / gocryptotrader

A cryptocurrency trading bot and framework supporting multiple exchanges written in Golang.
MIT License
2.95k stars 793 forks source link

gateio: update FuturesAccount and Position struct #1532

Closed shazbert closed 3 weeks ago

shazbert commented 2 months ago

PR Description

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and also consider improving test coverage whilst working on a certain feature or package.

Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 23.80952% with 16 lines in your changes missing coverage. Please review.

Project coverage is 36.26%. Comparing base (06b9980) to head (6c4688f).

:exclamation: Current head 6c4688f differs from pull request most recent head 59a10f1

Please upload reports for the commit 59a10f1 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1532/graphs/tree.svg?width=650&height=150&src=pr&token=41784B23TS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1532?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) ```diff @@ Coverage Diff @@ ## master #1532 +/- ## ========================================== - Coverage 36.28% 36.26% -0.03% ========================================== Files 419 419 Lines 183133 183133 ========================================== - Hits 66458 66408 -50 - Misses 108578 108622 +44 - Partials 8097 8103 +6 ``` | [Files](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1532?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) | Coverage Δ | | |---|---|---| | [exchanges/gateio/gateio\_types.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1532?src=pr&el=tree&filepath=exchanges%2Fgateio%2Fgateio_types.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2dhdGVpby9nYXRlaW9fdHlwZXMuZ28=) | `65.71% <ø> (ø)` | | | [exchanges/gateio/gateio\_convert.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1532?src=pr&el=tree&filepath=exchanges%2Fgateio%2Fgateio_convert.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2dhdGVpby9nYXRlaW9fY29udmVydC5nbw==) | `69.44% <83.33%> (ø)` | | | [exchanges/gateio/gateio\_wrapper.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1532?src=pr&el=tree&filepath=exchanges%2Fgateio%2Fgateio_wrapper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2dhdGVpby9nYXRlaW9fd3JhcHBlci5nbw==) | `40.04% <0.00%> (ø)` | | | [exchanges/gateio/gateio.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1532?src=pr&el=tree&filepath=exchanges%2Fgateio%2Fgateio.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2dhdGVpby9nYXRlaW8uZ28=) | `14.21% <0.00%> (ø)` | | ... and [19 files with indirect coverage changes](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1532/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)
shazbert commented 1 month ago

Got an update to the fee struct coming through. PAUSE. 🙏

shazbert commented 1 month ago

It is now pushed you can all relax and get back to reviewing this massive PR. 👍