thrasher-corp / gocryptotrader

A cryptocurrency trading bot and framework supporting multiple exchanges written in Golang.
MIT License
2.99k stars 802 forks source link

Bybit: Solana options #1533

Closed gloriousCode closed 5 months ago

gloriousCode commented 5 months ago

PR Description

Bybit has Solana options now. To allow everyone to use puts on SOL, I've implemented it here. Sadly Bybit doesn't have an API endpoint that says what options they support 😕

I also ensure that we retrieve all options in a loop

Type of change

How has this been tested

Checklist

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 36.02%. Comparing base (0676c78) to head (bd38d32).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1533/graphs/tree.svg?width=650&height=150&src=pr&token=41784B23TS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1533?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) ```diff @@ Coverage Diff @@ ## master #1533 +/- ## ========================================== - Coverage 36.02% 36.02% -0.01% ========================================== Files 411 411 Lines 176914 176920 +6 ========================================== - Hits 63741 63727 -14 - Misses 105393 105408 +15 - Partials 7780 7785 +5 ``` | [Files](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1533?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) | Coverage Δ | | |---|---|---| | [exchanges/bybit/bybit\_types.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1533?src=pr&el=tree&filepath=exchanges%2Fbybit%2Fbybit_types.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2J5Yml0L2J5Yml0X3R5cGVzLmdv) | `66.66% <ø> (ø)` | | | [exchanges/bybit/bybit\_wrapper.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1533?src=pr&el=tree&filepath=exchanges%2Fbybit%2Fbybit_wrapper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2J5Yml0L2J5Yml0X3dyYXBwZXIuZ28=) | `40.79% <75.00%> (-0.03%)` | :arrow_down: | ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1533/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)