thrasher-corp / gocryptotrader

A cryptocurrency trading bot and framework supporting multiple exchanges written in Golang.
MIT License
2.95k stars 793 forks source link

Bybit: Fix WS ticker processing #1538

Closed gbjk closed 5 days ago

gbjk commented 1 month ago

Type of change

How has this been tested

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 82.55814% with 15 lines in your changes missing coverage. Please review.

Project coverage is 36.23%. Comparing base (06b9980) to head (22179fa). Report is 6 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1538/graphs/tree.svg?width=650&height=150&src=pr&token=41784B23TS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) ```diff @@ Coverage Diff @@ ## master #1538 +/- ## ========================================== - Coverage 36.28% 36.23% -0.06% ========================================== Files 419 419 Lines 183133 182999 -134 ========================================== - Hits 66458 66308 -150 - Misses 108578 108623 +45 + Partials 8097 8068 -29 ``` | [Files](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1538?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) | Coverage Δ | | |---|---|---| | [exchanges/bybit/bybit\_types.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1538?src=pr&el=tree&filepath=exchanges%2Fbybit%2Fbybit_types.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2J5Yml0L2J5Yml0X3R5cGVzLmdv) | `66.66% <ø> (ø)` | | | [exchanges/ticker/ticker.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1538?src=pr&el=tree&filepath=exchanges%2Fticker%2Fticker.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL3RpY2tlci90aWNrZXIuZ28=) | `90.39% <ø> (ø)` | | | [exchanges/bybit/bybit\_websocket.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1538?src=pr&el=tree&filepath=exchanges%2Fbybit%2Fbybit_websocket.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2J5Yml0L2J5Yml0X3dlYnNvY2tldC5nbw==) | `46.04% <91.42%> (-0.52%)` | :arrow_down: | | [exchanges/bybit/bybit\_wrapper.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1538?src=pr&el=tree&filepath=exchanges%2Fbybit%2Fbybit_wrapper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2J5Yml0L2J5Yml0X3dyYXBwZXIuZ28=) | `40.65% <43.75%> (-0.09%)` | :arrow_down: | ... and [28 files with indirect coverage changes](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1538/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)