thrasher-corp / gocryptotrader

A cryptocurrency trading bot and framework supporting multiple exchanges written in Golang.
MIT License
2.95k stars 793 forks source link

protocol/order: adds additional fields for trading requirements #1552

Closed shazbert closed 5 days ago

shazbert commented 1 month ago

PR Description

Please delete options that are not relevant and add an x in [] as item is complete.

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and also consider improving test coverage whilst working on a certain feature or package.

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 59.64912% with 23 lines in your changes missing coverage. Please review.

Project coverage is 38.10%. Comparing base (06b9980) to head (b150d77). Report is 5 commits behind head on master.

:exclamation: Current head b150d77 differs from pull request most recent head 87b89f3

Please upload reports for the commit 87b89f3 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1552/graphs/tree.svg?width=650&height=150&src=pr&token=41784B23TS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) ```diff @@ Coverage Diff @@ ## master #1552 +/- ## ========================================== + Coverage 36.28% 38.10% +1.81% ========================================== Files 419 415 -4 Lines 183133 152256 -30877 ========================================== - Hits 66458 58011 -8447 + Misses 108578 86153 -22425 + Partials 8097 8092 -5 ``` | [Files](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1552?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) | Coverage Δ | | |---|---|---| | [engine/order\_manager.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1552?src=pr&el=tree&filepath=engine%2Forder_manager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZW5naW5lL29yZGVyX21hbmFnZXIuZ28=) | `67.11% <100.00%> (+1.64%)` | :arrow_up: | | [exchanges/binanceus/binanceus\_wrapper.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1552?src=pr&el=tree&filepath=exchanges%2Fbinanceus%2Fbinanceus_wrapper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2JpbmFuY2V1cy9iaW5hbmNldXNfd3JhcHBlci5nbw==) | `44.89% <100.00%> (+3.99%)` | :arrow_up: | | [exchanges/btcmarkets/btcmarkets\_wrapper.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1552?src=pr&el=tree&filepath=exchanges%2Fbtcmarkets%2Fbtcmarkets_wrapper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2J0Y21hcmtldHMvYnRjbWFya2V0c193cmFwcGVyLmdv) | `35.87% <100.00%> (+3.24%)` | :arrow_up: | | [exchanges/coinut/coinut\_wrapper.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1552?src=pr&el=tree&filepath=exchanges%2Fcoinut%2Fcoinut_wrapper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2NvaW51dC9jb2ludXRfd3JhcHBlci5nbw==) | `27.77% <100.00%> (+2.92%)` | :arrow_up: | | [exchanges/exchange.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1552?src=pr&el=tree&filepath=exchanges%2Fexchange.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2V4Y2hhbmdlLmdv) | `79.83% <100.00%> (+3.29%)` | :arrow_up: | | [exchanges/hitbtc/hitbtc\_wrapper.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1552?src=pr&el=tree&filepath=exchanges%2Fhitbtc%2Fhitbtc_wrapper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2hpdGJ0Yy9oaXRidGNfd3JhcHBlci5nbw==) | `50.00% <100.00%> (+4.62%)` | :arrow_up: | | [exchanges/kraken/kraken\_wrapper.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1552?src=pr&el=tree&filepath=exchanges%2Fkraken%2Fkraken_wrapper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2tyYWtlbi9rcmFrZW5fd3JhcHBlci5nbw==) | `43.61% <100.00%> (+2.62%)` | :arrow_up: | | [exchanges/kucoin/kucoin\_wrapper.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1552?src=pr&el=tree&filepath=exchanges%2Fkucoin%2Fkucoin_wrapper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2t1Y29pbi9rdWNvaW5fd3JhcHBlci5nbw==) | `37.64% <100.00%> (+2.84%)` | :arrow_up: | | [exchanges/order/orders.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1552?src=pr&el=tree&filepath=exchanges%2Forder%2Forders.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL29yZGVyL29yZGVycy5nbw==) | `90.29% <100.00%> (-0.13%)` | :arrow_down: | | [exchanges/alphapoint/alphapoint\_wrapper.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1552?src=pr&el=tree&filepath=exchanges%2Falphapoint%2Falphapoint_wrapper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2FscGhhcG9pbnQvYWxwaGFwb2ludF93cmFwcGVyLmdv) | `24.81% <0.00%> (+1.16%)` | :arrow_up: | | ... and [18 more](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1552?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) | | ... and [369 files with indirect coverage changes](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1552/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)