thrasher-corp / gocryptotrader

A cryptocurrency trading bot and framework supporting multiple exchanges written in Golang.
MIT License
2.95k stars 793 forks source link

currency: translation and matching pairs #1556

Open shazbert opened 1 month ago

shazbert commented 1 month ago

PR Description

Thanks.

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and also consider improving test coverage whilst working on a certain feature or package.

Checklist

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 96.92308% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.17%. Comparing base (258b60c) to head (2a32703).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1556/graphs/tree.svg?width=650&height=150&src=pr&token=41784B23TS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) ```diff @@ Coverage Diff @@ ## master #1556 +/- ## ========================================== + Coverage 36.26% 38.17% +1.91% ========================================== Files 419 419 Lines 183133 152380 -30753 ========================================== - Hits 66405 58165 -8240 + Misses 108643 86129 -22514 - Partials 8085 8086 +1 ``` | [Files](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1556?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) | Coverage Δ | | |---|---|---| | [currency/code\_types.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1556?src=pr&el=tree&filepath=currency%2Fcode_types.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-Y3VycmVuY3kvY29kZV90eXBlcy5nbw==) | `0.00% <ø> (ø)` | | | [exchanges/bybit/bybit\_wrapper.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1556?src=pr&el=tree&filepath=exchanges%2Fbybit%2Fbybit_wrapper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2J5Yml0L2J5Yml0X3dyYXBwZXIuZ28=) | `45.37% <100.00%> (+4.63%)` | :arrow_up: | | [exchanges/gateio/gateio\_wrapper.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1556?src=pr&el=tree&filepath=exchanges%2Fgateio%2Fgateio_wrapper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2dhdGVpby9nYXRlaW9fd3JhcHBlci5nbw==) | `42.93% <100.00%> (+3.29%)` | :arrow_up: | | [exchanges/kucoin/kucoin\_wrapper.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1556?src=pr&el=tree&filepath=exchanges%2Fkucoin%2Fkucoin_wrapper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2t1Y29pbi9rdWNvaW5fd3JhcHBlci5nbw==) | `37.76% <100.00%> (+2.85%)` | :arrow_up: | | [currency/translation.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1556?src=pr&el=tree&filepath=currency%2Ftranslation.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-Y3VycmVuY3kvdHJhbnNsYXRpb24uZ28=) | `94.28% <93.33%> (-5.72%)` | :arrow_down: | ... and [393 files with indirect coverage changes](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1556/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)