Deribit: bug fixes, test fixes and implement GetCurrencyTradeURL

[gloriousCode]

PR Description

These are the kinds of bugs that can only pop up after proper use, it was still an excellent PR Sam 🕊️

This PR does the following:

• Speeds up UpdateTradablePairs utilising concurrency since its so slow. Reduces go test -race -count=0 from 28s to 20s
• Implement GetCurrencyTradeURL
• Update function IsPerpetualFuture
• Update optionPairToString and add test coverage
• Simplifies some tests
• Rename guessAssetTypeFromInstrument to getAssetFromPair as its not guessing
• Adds getAssetPairByInstrument to help parse WS pair data after getting some errors
• Handles currency processing via the any subscriptions (eg trades) using getAssetPairByInstrument
  • This moves the parsing of currency data to inside loops, because any can have multiple currencies in the slice/ the currency isn't in the channel name
• Fix an issue with a lack of candle data due to incorrect kline choice (fixes large output about missing candle data in tests)
• Changed TestGetHistoricTrades to not check results, because sometimes there are no trades, but its an expensive test to go back further in time to ensure trades. If there is an issue, deribit will error.
• Stop checking orderbooks bid/ask len for options.

I made sure that getAssetPairByInstrument was performant before using it

func BenchmarkGetAssetPairByInstrumentFutures(b *testing.B) {
    b.ReportAllocs()
    for i := 0; i < b.N; i++ {
        _, _, err := d.getAssetPairByInstrument("DOGE_USDC-PERPETUAL")
        if err != nil {
            b.Fatal(err)
        }
    }
}

func BenchmarkGetAssetPairByInstrumentOptions(b *testing.B) {
    b.ReportAllocs()
    for i := 0; i < b.N; i++ {
        _, _, err := d.getAssetPairByInstrument("MATIC_USDC-3JUN24-0D64-P")
        if err != nil {
            b.Fatal(err)
        }
    }
}

func BenchmarkGetAssetPairByInstrumentSpot(b *testing.B) {
    b.ReportAllocs()
    for i := 0; i < b.N; i++ {
        _, _, err := d.getAssetPairByInstrument("DOGE_USDC")
        if err != nil {
            b.Fatal(err)
        }
    }
}

BenchmarkGetAssetPairByInstrumentFutures-10     11103615           108.5 ns/op        36 B/op          2 allocs/op
BenchmarkGetAssetPairByInstrumentOptions-10      7306069           139.4 ns/op        68 B/op          2 allocs/op
BenchmarkGetAssetPairByInstrumentSpot-10        12750432            96.06 ns/op       20 B/op          2 allocs/op

Type of change

• [x] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)

How has this been tested

• [x] go test ./... -race
• [x] golangci-lint run
• [x] TestOptionPairToString
• [x] GetCurrencyTradeURL

Checklist

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally and on Github Actions with my changes
• [x] Any dependent changes have been merged and published in downstream modules

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 73.60406% with 52 lines in your changes missing coverage. Please review.

Project coverage is 38.20%. Comparing base (c37a115) to head (bd5d4c9). Report is 5 commits behind head on master.

:exclamation: Current head bd5d4c9 differs from pull request most recent head 171915c

Please upload reports for the commit 171915c to get more accurate results.

Additional details and impacted files

[](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) ```diff @@ Coverage Diff @@ ## master #1558 +/- ## ========================================== + Coverage 37.78% 38.20% +0.41% ========================================== Files 409 419 +10 Lines 147697 152314 +4617 ========================================== + Hits 55807 58191 +2384 - Misses 84031 86023 +1992 - Partials 7859 8100 +241 ``` | [Files](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1558?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) | Coverage Δ | | |---|---|---| | [exchanges/kline/kline.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1558?src=pr&el=tree&filepath=exchanges%2Fkline%2Fkline.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2tsaW5lL2tsaW5lLmdv) | `91.78% <100.00%> (+0.05%)` | :arrow_up: | | [exchanges/orderbook/orderbook.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1558?src=pr&el=tree&filepath=exchanges%2Forderbook%2Forderbook.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL29yZGVyYm9vay9vcmRlcmJvb2suZ28=) | `92.26% <100.00%> (ø)` | | | [exchanges/deribit/deribit.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1558?src=pr&el=tree&filepath=exchanges%2Fderibit%2Fderibit.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2RlcmliaXQvZGVyaWJpdC5nbw==) | `45.89% <87.50%> (ø)` | | | [exchanges/deribit/deribit\_websocket.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1558?src=pr&el=tree&filepath=exchanges%2Fderibit%2Fderibit_websocket.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2RlcmliaXQvZGVyaWJpdF93ZWJzb2NrZXQuZ28=) | `42.68% <64.15%> (ø)` | | | [exchanges/deribit/deribit\_wrapper.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1558?src=pr&el=tree&filepath=exchanges%2Fderibit%2Fderibit_wrapper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2RlcmliaXQvZGVyaWJpdF93cmFwcGVyLmdv) | `43.68% <72.27%> (ø)` | | ... and [70 files with indirect coverage changes](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1558/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)