Subscription Templating

[gbjk]

• Adds templating to Subscriptions to unify the repetitive fan-out of assets and pairs we keep doing
• Adds QualifiedChannel field to separate out the path for a channel from it's entity type
  • Considered naming this Path or URN, etc
  • Considered renaming Channel to Type
  • This felt the least invasive. Open to suggestions though.
• ⛔ Backwards incompatible with Binance subscription configuration unfortunately.
• Adds Subscriptions utils List.SetStates and List.AssetPairs

Will consume this in existing exchanges if this flies and merges.

Type of change

• [x] New feature (non-breaking change which adds functionality)
• [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested

• [x] go test ./... -race
• [x] golangci-lint run

[gbjk]

Just going from this conversation. I had an old config that wasn't upgrading correctly.

Doh. Lost a line at somepoint.

Fixed 3f1c14e

[gbjk]

I'm having difficulty with regards to the new backwards compatability:

Sorry about that.

Fixed ac6da76

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 88.88889% with 21 lines in your changes missing coverage. Please review.

Project coverage is 38.19%. Comparing base (98f025e) to head (f166d90). Report is 4 commits behind head on master.

Additional details and impacted files

[](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) ```diff @@ Coverage Diff @@ ## master #1568 +/- ## ========================================== + Coverage 36.26% 38.19% +1.92% ========================================== Files 419 420 +1 Lines 183133 152412 -30721 ========================================== - Hits 66421 58207 -8214 + Misses 108605 86125 -22480 + Partials 8107 8080 -27 ``` | [Files](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1568?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp) | Coverage Δ | | |---|---|---| | [exchanges/binance/binance.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1568?src=pr&el=tree&filepath=exchanges%2Fbinance%2Fbinance.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2JpbmFuY2UvYmluYW5jZS5nbw==) | `48.22% <ø> (+3.14%)` | :arrow_up: | | [exchanges/subscription/keys.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1568?src=pr&el=tree&filepath=exchanges%2Fsubscription%2Fkeys.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL3N1YnNjcmlwdGlvbi9rZXlzLmdv) | `100.00% <ø> (+12.82%)` | :arrow_up: | | [exchanges/subscription/list.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1568?src=pr&el=tree&filepath=exchanges%2Fsubscription%2Flist.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL3N1YnNjcmlwdGlvbi9saXN0Lmdv) | `100.00% <100.00%> (ø)` | | | [exchanges/subscription/store.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1568?src=pr&el=tree&filepath=exchanges%2Fsubscription%2Fstore.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL3N1YnNjcmlwdGlvbi9zdG9yZS5nbw==) | `100.00% <100.00%> (+4.79%)` | :arrow_up: | | [exchanges/subscription/subscription.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1568?src=pr&el=tree&filepath=exchanges%2Fsubscription%2Fsubscription.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL3N1YnNjcmlwdGlvbi9zdWJzY3JpcHRpb24uZ28=) | `100.00% <100.00%> (+4.16%)` | :arrow_up: | | [exchanges/binance/binance\_wrapper.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1568?src=pr&el=tree&filepath=exchanges%2Fbinance%2Fbinance_wrapper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2JpbmFuY2UvYmluYW5jZV93cmFwcGVyLmdv) | `41.22% <66.66%> (+2.76%)` | :arrow_up: | | [exchanges/exchange.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1568?src=pr&el=tree&filepath=exchanges%2Fexchange.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2V4Y2hhbmdlLmdv) | `79.64% <50.00%> (+3.09%)` | :arrow_up: | | [exchanges/subscription/template.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1568?src=pr&el=tree&filepath=exchanges%2Fsubscription%2Ftemplate.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL3N1YnNjcmlwdGlvbi90ZW1wbGF0ZS5nbw==) | `97.18% <97.18%> (ø)` | | | [internal/testing/subscriptions/subscriptions.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1568?src=pr&el=tree&filepath=internal%2Ftesting%2Fsubscriptions%2Fsubscriptions.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-aW50ZXJuYWwvdGVzdGluZy9zdWJzY3JpcHRpb25zL3N1YnNjcmlwdGlvbnMuZ28=) | `51.85% <62.50%> (+51.85%)` | :arrow_up: | | [exchanges/binance/binance\_websocket.go](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1568?src=pr&el=tree&filepath=exchanges%2Fbinance%2Fbinance_websocket.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp#diff-ZXhjaGFuZ2VzL2JpbmFuY2UvYmluYW5jZV93ZWJzb2NrZXQuZ28=) | `59.61% <80.00%> (+2.24%)` | :arrow_up: | ... and [388 files with indirect coverage changes](https://app.codecov.io/gh/thrasher-corp/gocryptotrader/pull/1568/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thrasher-corp)