I had both values populated for Amount and QuoteAmount and when it detected base amount it kept base amount. So this reduces a fat finger chance. 😆
Type of change
Please delete options that are not relevant and add an x in [] as item is complete.
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
[ ] go test ./... -race
[ ] golangci-lint run
[ ] Test X
Checklist
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally and on Github Actions with my changes
[ ] Any dependent changes have been merged and published in downstream modules
PR Description
I had both values populated for Amount and QuoteAmount and when it detected base amount it kept base amount. So this reduces a fat finger chance. 😆
Type of change
Please delete options that are not relevant and add an
x
in[]
as item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and also consider improving test coverage whilst working on a certain feature or package.
Checklist