search

thrau / jarchivelib

A simple archiving and compression library for Java
https://github.com/thrau/jarchivelib
Apache License 2.0
198 stars 36 forks source link

Issue #36; support extraction from a stream. #37

Closed benson-basis closed 9 years ago

benson-basis commented 9 years ago

Here's an implementation of 'extract-from-a-stream'.

benson-basis commented 9 years ago

I've made the requested changes to add support in the decorator, and all the tests pass. I'm having trouble finding a place to add a test for the new case.

benson-basis commented 9 years ago

Adjustments Pushed.

thrau commented 9 years ago

The test case extract_properlyExtractsArchiveStream in AbstractArchiverTest covers the ArchiverCompressorDecorator via the ArchiverTarGzTest, so its fine. Just needs to be fixed

benson-basis commented 9 years ago

Hmm. 7zip rejects streaming. How do we set up the test to be graceful? Or do you want me to implement the temp file fallback for that case?

thrau commented 9 years ago

I'll fix the test. Thanks a lot for the contribution!

benson-basis commented 9 years ago

I've got a temp-file solution I could push.

thrau commented 9 years ago

Already done :-) thanks though

benson-basis commented 9 years ago

Cool, since the temp file idea is proving a lot harder than I thought it would be. You're welcome.

thrau commented 9 years ago

Scratch that last one - I forgot the SevenZArchiver :-) however i still think its fine to live with the limitation for now.

benson-basis commented 9 years ago

So as per previous comment I'm thinking I'm done here :-)