search

thrau / jarchivelib

A simple archiving and compression library for Java
https://github.com/thrau/jarchivelib
Apache License 2.0
198 stars 36 forks source link

Use PosixFilePermissions to set file permissions instead of using reflection #72

Closed cliffcotino closed 5 years ago

cliffcotino commented 5 years ago

This also makes it possible to run on JDK versions >= 9

robin-anil commented 5 years ago

Any plans of merging this in soon?

thrau commented 5 years ago

sorry i just haven't found the time yet to have a closer look at it. i have concerns about anything that requires Java > 6 in the current major release. seeing as the pressure is building up to upgrade, i may just release 1.0 as is and start 2.x with java 7. i'll free some time this weekend to look into it.

cliffcotino commented 5 years ago

if there's a 2.x branch available, I would be glad to base my changes on that

thrau commented 5 years ago

@cliffcotino could you rebase your changes to the current master? i reorganized the milestones and will release 1.0.0 once your changes are merged.

cliffcotino commented 5 years ago

I just rebased the changes as requested.

thrau commented 5 years ago

Those are excellent changes, thank you very much for the contribution!