threaTrace-detector / threaTrace

MIT License
83 stars 22 forks source link

Concern about consulting testing sets while training #5

Open ahmed3amerai opened 1 year ago

ahmed3amerai commented 1 year ago

Hi, I managed to partially reproduce the paper results, and I am trying to understand the training script for DARPA TC3. I noticed the script validates each trained model with the testing dataset and deletes any model with poor performance, i.e. Recall less than 0.8 and precision less than 0.7. If my understanding is correct, why does the training script consult testing sets for validation? would it affect the model performance with unseen data? Regards,

ahmed3amerai commented 1 year ago

Following this issue,

Chaves2021 commented 7 months ago

Hey. Have you been answered? I have the same doubt.

Thanks :)