search

thread-pond / signature-pad

A jQuery plugin for assisting in the creation of an HTML5 canvas based signature pad. Records the drawn signature in JSON for later regeneration.
BSD 3-Clause "New" or "Revised" License
730 stars 290 forks source link

Touch Event is not working #136

Closed albertwchang closed 9 years ago

albertwchang commented 9 years ago

When toggling Device Mode to mobile (Chrome v38), the canvas doesn't allow drawing. Example: try to use the following demo in mobile mode. http://thomasjbradley.ca/lab/signature-pad/accept/

screen shot 2014-11-21 at 1 42 57 pm

thomasjbradley commented 9 years ago

Do you have any ideas how to fix that? It works in Chrome on Android, right?

albertwchang commented 9 years ago

No idea at the moment on a fix. I also tried selecting 3 different Android devices (Nexus 7, Samsung S4, etc.); but the problem persists. I'm guessing the canvas allows signing for mobile only on web applications (not natively-wrapped apps like Phonegap)?

I haven't seen an Angular variant out there; so the opportunity awaits, I guess.

thomasjbradley commented 9 years ago

It definitely works on mobile browsers and as far as I know should work in wrappers like PhoneGap. The bug you're running into is specific to Chrome's mobile emulation system.

albertwchang commented 9 years ago

Hey Bradley. I just created a (my first) pull request on GitHub. Hopefully I didn't mess anything up; but take a look at the change I made. Fixed the problem; but not sure if I screwed up something by removing usage of the .each() function...

On Sat, Nov 22, 2014 at 3:59 PM, Thomas J Bradley notifications@github.com wrote:

It definitely works on mobile browsers and as far as I know should work in wrappers like PhoneGap. The bug you're running into is specific to Chrome's mobile emulation system.

— Reply to this email directly or view it on GitHub https://github.com/thomasjbradley/signature-pad/issues/136#issuecomment-64100335 .

thomasjbradley commented 9 years ago

Thanks!