search

thread-pond / signature-pad

A jQuery plugin for assisting in the creation of an HTML5 canvas based signature pad. Records the drawn signature in JSON for later regeneration.
BSD 3-Clause "New" or "Revised" License
727 stars 292 forks source link

Links to demos no longer work #195

Open ryanshripat opened 6 years ago

ryanshripat commented 6 years ago

Links such as https://thomasjbradley.github.io/signature-pad/examples/accept-signature.html (linked from readme) return a 404 ("There isn't a GitHub Pages site here."). If you tell me where I can link to instead, I can update the documentation. Otherwise, I can attempt to provide a different URL by hosting the demos elsewhere (perhaps on github.io).

mockdeep commented 6 years ago

Hey @ryanshripat I could be wrong, but it looks like things should probably work if we change the urls to map to https://thread-pond.github.io/signature-pad/ instead. If you want to PR it, I'd be happy to merge it!

ryanshripat commented 6 years ago

I'd love to submit a PR, @mockdeep but both that link and https://thread-pond.github.io/ give the "There isn't a GitHub Pages site here" error. I suspect that the repo owner will be able to actually create a Pages site at that URL. In the meantime I can read up on the following: https://help.github.com/articles/user-organization-and-project-pages/

mockdeep commented 6 years ago

@ryanshripat Oh, interesting. So it looks like the nested urls are available on the local GH pages, but for some reason the root url is not. This link works for me:

https://thread-pond.github.io/signature-pad/examples/accept-signature.html

It looks like the project pages will be available locally based on the repo, which the docs you share confirm in the Project Pages section, but it doesn't tell us how to get the root working. Just looking at a random other project, it looks like react-native has an index.html in the root of the project:

https://github.com/facebook/react-native/tree/gh-pages