search

thread-pond / signature-pad

A jQuery plugin for assisting in the creation of an HTML5 canvas based signature pad. Records the drawn signature in JSON for later regeneration.
BSD 3-Clause "New" or "Revised" License
727 stars 292 forks source link

Android and phonegap - flashing's popup after clicking on cancel button #206

Open MobideoNetser opened 5 years ago

MobideoNetser commented 5 years ago

Hello,

  1. After I upgraded the version to the last one, it cause bug of flashing's popup. This is the scenario: Open popup with signature pad and do nothing-> click on cancel button and close the popup-> open again the popup -> Excepted result= the popup open with the signature pad Actual result= the popup did not open and the screen is flashing.

I'm using phonegap on android with javascript and bootstrap. This bug can't reproduce on Iphone.

This are the functions that were changed in the new version. stopDrawing startDrawing disableCanvas initDrawEvents drawIt

  1. Do you have a versions inside the file? It is very hard to understand which version is on my source control in case of upgrade or downgrade.

Thanks

mockdeep commented 5 years ago

Hi @MobideoNetser, thanks for reporting this issue. Unfortunately, I don't think I'm going to get a chance to look into it in the near future. If you're up for working on it yourself, I'd be happy to review a pull request.

hassaanalansary commented 4 years ago

I know this is very old ticket. But here is my 5cents @MobideoNetser i was using the signature in bootstrap pop up also. I had the issue where it doesn't close correctly and the background stay dimmed or grayed out even after the modal disappear. I remember that the fix was not related to signature, it was related to how you are closing the modal.

You can try to explicitly hide or remove the pop up altogether upon closing. And not rely on bootstrap to do it for you. Hope this can help.