search

thread-pond / signature-pad

A jQuery plugin for assisting in the creation of an HTML5 canvas based signature pad. Records the drawn signature in JSON for later regeneration.
BSD 3-Clause "New" or "Revised" License
727 stars 292 forks source link

Signature not appearing on iPhone #223

Open divyang-dv opened 2 years ago

divyang-dv commented 2 years ago

The Signature on an iPhone disappears as soon as you sign it. It works if you are using Chrome but doesn't work on Safari browser.

ghost commented 1 year ago

Hi, Did you solve this issue?

mockdeep commented 1 year ago

@lujain235 we haven't had any complaints from our users about this. Are you seeing issues? I'm not sure I'll have time to look into it, but if you want to make a PR I'll be happy to take a look.

ghost commented 1 year ago

@mockdeep thanks for reply. yes we are facing this issue on iPhone (ios 16) Here is a video of the issue I thought it might be a resizing issue so i stopped the canvas resize code but the issue wasn't solved. Can you please take a look and advise. thanks.

mockdeep commented 1 year ago

@lujain235 I'm unfortunately not at all familiar with the code in this repo, so I can't offer much. I'll try to set aside some time to look into it some more and see if I can understand what is happening.

ghost commented 1 year ago

Hi @mockdeep The issue has been resolved by setting drawBezierCurves = false.

mockdeep commented 1 year ago

@lujain235 you must not be using this library. It doesn't have any references to drawBezierCurves.

donkitchen commented 1 year ago

Hi @mockdeep The issue has been resolved by setting drawBezierCurves = false.

Where did you set this? I'm having the same issues in our app.

mockdeep commented 1 year ago

@donkitchen @lujain235 where are you pulling the signature pad library from?

ghost commented 1 year ago

@donkitchen @mockdeep Sorry for the conflicts, it turns out that our developers used another code for Bezier Curves and merged it with this library, and that was the cause of the issue, when i stopped it the library works. (when i added my comment i didn't know that this code had been added to the library by our team)

donkitchen commented 1 year ago

@donkitchen @lujain235 where are you pulling the signature pad library from?

I downloaded the js library from here. I am not, however, using the styles that you guys have for the examples.

Since the example linked in the repo works on my device, I suspect it may be a CSS/style thing, which I am going to verify today. I updated my code to use the latest JS library and that didn't make a difference, so the styles are my next guess.

I don't really want to focus on the ones that change the look, more anything that may be functional, which is why I'm going to try the .pad class first.

donkitchen commented 1 year ago

I believe the problem seems to be my use case of having two signature elements on the same page. I didn't see a demo of that so I can't know if that actually does still work now or not.

I've been trying to troubleshoot by making each class unique and passing those element names in as options, but not having any luck yet.

Is anybody else using two signatures on one page? If they are, is it still working on IOS16?

mockdeep commented 1 year ago

We display a lot of signatures on the same page and haven't had any reports of it not working for people on IOS. Are you able to provide a code sample the reproduces the issue?

donkitchen commented 1 year ago

Yes, I'll work on that -- if you are willing, it may be easier for me to give you instructions on how you can access my stuff, with a brief video on how you would test it. Since it's all HTML, CSS and JS you would easily be able to see all of the pieces working together.

mockdeep commented 1 year ago

Sure, that works too.

donkitchen commented 1 year ago

Sure, that works too.

Sent you an email @mockdeep